Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): DLT-1758 add legacy styles back #326

Merged
merged 2 commits into from
May 23, 2024

Conversation

braddialpad
Copy link
Contributor

fix(tooltip): add legacy styles back

Obligatory GIF (super important!)

Obligatory GIF

πŸ› οΈ Type Of Change

These types will increment the version number on release:

  • Fix

πŸ“– Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1758

πŸ“– Description

Adding legacy tooltip styles back in, even though they are not used in the vue component anymore, DPM still uses them. Shouldn't hurt anything to keep them.

Also fixes the issues on tooltip docs page.

πŸ“ Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

Copy link

βœ”οΈ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-326/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-326/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-326/

@braddialpad braddialpad added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label May 23, 2024
@braddialpad braddialpad changed the title fix(tooltip): add legacy styles back fix(tooltip): DLT-1758 add legacy styles back May 23, 2024
@braddialpad braddialpad merged commit 79d087b into staging May 23, 2024
10 of 11 checks passed
@braddialpad braddialpad deleted the fix/tooltip-styles branch May 23, 2024 21:22
@braddialpad
Copy link
Contributor Author

Merging, since this is basically just a revert

juliodialpad pushed a commit that referenced this pull request May 23, 2024
# [9.39.0](dialtone/v9.38.2...dialtone/v9.39.0) (2024-05-23)

### Bug Fixes

* **Tooltip:** DLT-1758 add legacy styles back ([#326](#326)) ([79d087b](79d087b))

### Documentation

* **Homepage:** NO-JIRA homepage svg loader and stack ([#325](#325)) ([e66ed5c](e66ed5c))

### Features

* dlt-1397 init empty state ([#315](#315)) ([38d3103](38d3103))
* **Link:** DLT-1631 add inverted utility classes ([#321](#321)) ([0aa8259](0aa8259))
* **Message Input:** DLT-1767 add ability to disallow codeblock ([#327](#327)) ([c47ab66](c47ab66))
Copy link

πŸŽ‰ This PR is included in version 9.39.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

juliodialpad pushed a commit that referenced this pull request May 23, 2024
# [8.32.0](dialtone-css/v8.31.2...dialtone-css/v8.32.0) (2024-05-23)

### Bug Fixes

* **Tooltip:** DLT-1758 add legacy styles back ([#326](#326)) ([79d087b](79d087b))

### Features

* dlt-1397 init empty state ([#315](#315)) ([38d3103](38d3103))
* **Link:** DLT-1631 add inverted utility classes ([#321](#321)) ([0aa8259](0aa8259))
Copy link

πŸŽ‰ This PR is included in version 8.32.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant