Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DLT-1731 skin tone emojis #329

Merged
merged 8 commits into from
May 28, 2024
Merged

fix: DLT-1731 skin tone emojis #329

merged 8 commits into from
May 28, 2024

Conversation

juliodialpad
Copy link
Collaborator

Detect skin tone emojis on rich text editor emoji plugin

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1731

📖 Description

  • Changed emoji-regex dependency to regex-combined-emojis that seems to be more maintained and up-to-date.
  • Updated emoji input rule to return shortcode instead of emoji, if we already found the emoji and know that it is valid, why we would need to send unicode and having to transform it again?

💡 Context

Skin tone emojis were not being detected correctly.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script

📷 Screenshots / GIFs

Before

Screen.Recording.2024-05-24.at.12.44.36.p.m.mov

After

Screen.Recording.2024-05-24.at.12.37.56.p.m.mov

@juliodialpad juliodialpad self-assigned this May 24, 2024
@github-actions GitHub Actions
Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@juliodialpad juliodialpad added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label May 24, 2024
@braddialpad @juliodialpad
fix(rich-text-editor): DLT-1752 remove custom parsing (#331)
3f0c6c1 
Co-authored-by: Julio Ortega <julio.ortega@dialpad.com>
braddialpad and others added 4 commits May 28, 2024 11:55
@braddialpad
docs(button): NO-JIRA add disabled class docs back into examples (#333)
8ea5249
@juliodialpad
fix skin tone variation emojis
1564c79
@juliodialpad
fix skin tone variation emojis -vue 3
7c48793
@juliodialpad
Merge remote-tracking branch 'origin/fix/skin-tone-emojis' into fix/s…
1a5f16d 
…kin-tone-emojis

# Conflicts:
#	packages/dialtone-vue2/components/rich_text_editor/rich_text_editor.vue
#	packages/dialtone-vue3/components/rich_text_editor/rich_text_editor.vue
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-329/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-329/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-329/

@juliodialpad juliodialpad merged commit 08d0cb3 into staging May 28, 2024
11 checks passed
@juliodialpad juliodialpad deleted the fix/skin-tone-emojis branch May 28, 2024 20:53
juliodialpad pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.40.0
9f1387e 
# [9.40.0](dialtone/v9.39.0...dialtone/v9.40.0) (2024-05-30)

### Bug Fixes

* DLT-1731 skin tone emojis ([#329](#329)) ([08d0cb3](08d0cb3))
* **Rich Text Editor:** DLT-1752 remove custom parsing ([#331](#331)) ([3f0c6c1](3f0c6c1))
* **Tooltip:** DLT-1776 shown event trigger ([#335](#335)) ([404bda4](404bda4))

### Documentation

* **Button:** NO-JIRA add disabled class docs back into examples ([#333](#333)) ([8ea5249](8ea5249))
* dlt-1579 use CodeExampleTabs from Tabs to Validation messages ([#332](#332)) ([947c35f](947c35f))
* NO-JIRA update badges ([#334](#334)) ([1f6e61e](1f6e61e))
* **Tokens:** DLT-1635 add tokens examples for each category ([#324](#324)) ([5128728](5128728))

### Features

* NO-JIRA add launchpad icon ([#336](#336)) ([30b3e66](30b3e66))
juliodialpad pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.135.0
f31b54f 
# [2.135.0](dialtone-vue2/v2.134.0...dialtone-vue2/v2.135.0) (2024-05-30)

### Bug Fixes

* DLT-1731 skin tone emojis ([#329](#329)) ([08d0cb3](08d0cb3))
* **Rich Text Editor:** DLT-1752 remove custom parsing ([#331](#331)) ([3f0c6c1](3f0c6c1))
* **Tooltip:** DLT-1776 shown event trigger ([#335](#335)) ([404bda4](404bda4))

### Features

* **Badge:** DLT-1777 subtle and outlined variants ([#338](#338)) ([1da1fe9](1da1fe9))
* NO-JIRA add launchpad icon ([#336](#336)) ([30b3e66](30b3e66))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.135.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

juliodialpad pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.128.0
e898913 
# [3.128.0](dialtone-vue3/v3.127.0...dialtone-vue3/v3.128.0) (2024-05-30)

### Bug Fixes

* DLT-1731 skin tone emojis ([#329](#329)) ([08d0cb3](08d0cb3))
* **Rich Text Editor:** DLT-1752 remove custom parsing ([#331](#331)) ([3f0c6c1](3f0c6c1))
* **Tooltip:** DLT-1776 shown event trigger ([#335](#335)) ([404bda4](404bda4))

### Features

* **Badge:** DLT-1777 subtle and outlined variants ([#338](#338)) ([1da1fe9](1da1fe9))
* NO-JIRA add launchpad icon ([#336](#336)) ([30b3e66](30b3e66))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.128.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@juliodialpad juliodialpad

Labels
released visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliodialpad @braddialpad @ninamarina