Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utility): NO-JIRA border color opacity utility #356

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ninamarina
Copy link
Contributor

@ninamarina ninamarina commented Jun 7, 2024

fix: NO-JIRA border color opacity utility

The utility d-bco{n} was at some point generated as d-bco-{n}. We think this was unintended because the docs show d-bco{n}, and the rest of the utilities for opacity follow that same pattern.

Before Now
image image

Copy link

github-actions bot commented Jun 7, 2024

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@ninamarina ninamarina added the no-visual-test Add this tag when the PR does not need visual testing label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-356/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-356/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-356/

@ninamarina ninamarina marked this pull request as ready for review June 7, 2024 20:18
Copy link
Contributor

@francisrupert francisrupert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Change PR title to fix(css-utility): NO-JIRA corrected border color opacity name

@braddialpad braddialpad changed the title fix: NO-JIRA border color opacity utility fix(utility): NO-JIRA border color opacity utility Jun 10, 2024
@braddialpad braddialpad merged commit a0e4d08 into staging Jun 10, 2024
12 checks passed
@braddialpad braddialpad deleted the fix/d-bco-utility branch June 10, 2024 19:48
juliodialpad pushed a commit that referenced this pull request Jun 11, 2024
# [9.45.0](dialtone/v9.44.0...dialtone/v9.45.0) (2024-06-11)

### Bug Fixes

* **Utility:** NO-JIRA border color opacity utility ([#356](#356)) ([a0e4d08](a0e4d08))

### Features

* **Badge:** DLT-1788 design tokens for subtle and outline variants ([#358](#358)) ([4e008b7](4e008b7))
* **Chip:** NO-JIRA update chip bg colors ([#355](#355)) ([52a5043](52a5043))
* **Tooltip:** DLT-1793 new prop to set tippy theme ([#357](#357)) ([0bd6f3a](0bd6f3a))
juliodialpad pushed a commit that referenced this pull request Jun 11, 2024
# [8.36.0](dialtone-css/v8.35.0...dialtone-css/v8.36.0) (2024-06-11)

### Bug Fixes

* **Utility:** NO-JIRA border color opacity utility ([#356](#356)) ([a0e4d08](a0e4d08))

### Features

* **Badge:** DLT-1788 design tokens for subtle and outline variants ([#358](#358)) ([4e008b7](4e008b7))
* **Chip:** NO-JIRA update chip bg colors ([#355](#355)) ([52a5043](52a5043))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants