fix(message-input): NO-JIRA preventTyping not working with pills #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bianca-artola-dialpad
added
the
no-visual-test
bianca-artola-dialpad
requested review from
juliodialpad,
iropolo,
francisrupert,
braddialpad and
ninamarina
as code owners
|
✔️ Deploy previews ready! |
braddialpad
approved these changes
Jun 18, 2024
juliodialpad
pushed a commit
that referenced
this pull request
Jun 18, 2024
# [9.49.0](dialtone/v9.48.0...dialtone/v9.49.0) (2024-06-18) ### Bug Fixes * **Message Input:** NO-JIRA preventTyping not working with pills ([#375](#375)) ([1091d61](1091d61)) * **Rich Text Editor:** DLT-1822 inputs with line breaks are not working for editor ([#374](#374)) ([d0d16de](d0d16de)) ### Features * **Icon:** DLT-1804 add webex ([#367](#367)) ([72cab26](72cab26))
juliodialpad
pushed a commit
that referenced
this pull request
Jun 18, 2024
## [2.139.2](dialtone-vue2/v2.139.1...dialtone-vue2/v2.139.2) (2024-06-18) ### Bug Fixes * **Message Input:** NO-JIRA preventTyping not working with pills ([#375](#375)) ([1091d61](1091d61)) * **Rich Text Editor:** DLT-1822 inputs with line breaks are not working for editor ([#374](#374)) ([d0d16de](d0d16de))
juliodialpad
pushed a commit
that referenced
this pull request
Jun 18, 2024
## [3.132.2](dialtone-vue3/v3.132.1...dialtone-vue3/v3.132.2) (2024-06-18) ### Bug Fixes * **Message Input:** NO-JIRA preventTyping not working with pills ([#375](#375)) ([1091d61](1091d61)) * **Rich Text Editor:** DLT-1822 inputs with line breaks are not working for editor ([#374](#374)) ([d0d16de](d0d16de))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(message-input): NO-JIRA preventTyping not working with pills
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Description
We need to disallow typing when a pill is selected.
💡 Context
The fix I introduced to prevent users typing #371 when a pill is present did not work.
The problem seems to be that the old value (
this.value) is something like this<meeting-pill text="Start a meeting" close-button-aria-label="Delete meeting pill"/>whilevalueis something like/dpm{newCharacter}, so when we didvalue.length > this.value.lengththe first time, it returned false and the value was updated.So the fix I made this time was to disallow typing if keyCode is different from 8 (backspace key), so we don't need to register the length of the old and new values. If you come up with something better, please let me know, but so far this is the best I have found.