Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expressive-theme): NO-JIRA corrected figma and tokens studio connection #384

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

francisrupert
Copy link
Contributor

Corrected Figma and Tokens Studio connection

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

📖 Description

The Tokens Studio connection was incorrect. It was incorrectly on Dark Mode and Typography weren't associated with Expressive theme.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

@francisrupert francisrupert added the no-visual-test Add this tag when the PR does not need visual testing label Jun 25, 2024
@francisrupert francisrupert self-assigned this Jun 25, 2024
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-384/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-384/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-384/

@francisrupert francisrupert changed the title fix(expressive-theme): NO JIRA corrected figma and tokens studio connection fix(expressive-theme): NO-JIRA corrected figma and tokens studio connection Jun 25, 2024
@francisrupert francisrupert merged commit 255936f into staging Jun 25, 2024
6 of 10 checks passed
@francisrupert francisrupert deleted the correct-expressive-figma-connection branch June 25, 2024 22:37
juliodialpad pushed a commit that referenced this pull request Jul 1, 2024
# [9.51.0](dialtone/v9.50.0...dialtone/v9.51.0) (2024-07-01)

### Bug Fixes

* **Badge:** DP-102533 mention only color ([#386](#386)) ([b6dc77d](b6dc77d))
* **Emoji Picker:** DP-102475 fix keyboard navigation ([#389](#389)) ([6ca1d16](6ca1d16))
* **Expressive Theme:** NO-JIRA corrected figma and tokens studio connection ([#384](#384)) ([255936f](255936f))
* **Logo:** DLT-1833 corrected antialiased edging  ([#381](#381)) ([67322e6](67322e6))

### Documentation

* DLT-1765 update favicon to Ai logomark ([#378](#378)) ([59ff0a4](59ff0a4))
* DLT-1791 move storybook to doc site -  Avatar to ButtonGroup ([#380](#380)) ([b754575](b754575))
* DLT-1792 move storybook to doc site - Card to Combobox ([#383](#383)) ([56fbb43](56fbb43))
* **Prototypes:** DLT-1740 left bar prototype - vue 2 ([#385](#385)) ([689af1b](689af1b))
* **Prototypes:** DLT-1740 left bar prototype ([#368](#368)) ([b0e3c9a](b0e3c9a))

### Features

* **Icon:** DLT-1712 add token icon  ([#388](#388)) ([66d2474](66d2474))
* **Popover:** DLT-1826 appendTo root ([#379](#379)) ([4d2c54d](4d2c54d))
* **Popover:** DLT-1826 appendTo root ([#382](#382)) ([35480c5](35480c5))
juliodialpad pushed a commit that referenced this pull request Jul 1, 2024
## [1.31.1](dialtone-tokens/v1.31.0...dialtone-tokens/v1.31.1) (2024-07-01)

### Bug Fixes

* **Expressive Theme:** NO-JIRA corrected figma and tokens studio connection ([#384](#384)) ([255936f](255936f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant