Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): DLT-1846 inverted not working properly #398

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Jul 8, 2024

Fix Tooltip - Inverted not working properly

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1846

📖 Description

  • Change theme prop default value from 'undefined' to 'null'.

💡 Context

  • The theme was not reverting correctly after toggling inverted prop.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.

For all Vue changes:

  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script

📷 Screenshots / GIFs

  • Before
Screen.Recording.2024-07-08.at.9.48.26.a.m.mov
  • After
Screen.Recording.2024-07-08.at.9.45.59.a.m.mov

Copy link

github-actions bot commented Jul 8, 2024

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

Copy link

github-actions bot commented Jul 8, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-398/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-398/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-398/

@juliodialpad juliodialpad merged commit af57943 into staging Jul 8, 2024
11 checks passed
@juliodialpad juliodialpad deleted the fix/tooltip/inverted-not-working-properly branch July 8, 2024 16:57
juliodialpad pushed a commit that referenced this pull request Jul 8, 2024
## [9.54.1](dialtone/v9.54.0...dialtone/v9.54.1) (2024-07-08)

### Bug Fixes

* **Emoji Picker:** NO-JIRA fix keyboard proposal ([#393](#393)) ([e5e7dfa](e5e7dfa))
* **Input:** NO-JIRA content not displaying on right slot ([168af7c](168af7c))
* **Tooltip:** DLT-1846 inverted not working properly ([#398](#398)) ([af57943](af57943))
juliodialpad pushed a commit that referenced this pull request Jul 8, 2024
## [2.142.1](dialtone-vue2/v2.142.0...dialtone-vue2/v2.142.1) (2024-07-08)

### Bug Fixes

* **Emoji Picker:** NO-JIRA fix keyboard proposal ([#393](#393)) ([e5e7dfa](e5e7dfa))
* **Tooltip:** DLT-1846 inverted not working properly ([#398](#398)) ([af57943](af57943))
juliodialpad pushed a commit that referenced this pull request Jul 8, 2024
## [3.135.1](dialtone-vue3/v3.135.0...dialtone-vue3/v3.135.1) (2024-07-08)

### Bug Fixes

* **Emoji Picker:** NO-JIRA fix keyboard proposal ([#393](#393)) ([e5e7dfa](e5e7dfa))
* **Tooltip:** DLT-1846 inverted not working properly ([#398](#398)) ([af57943](af57943))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants