fix(callbox): correct color on voice chat icon #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
braddialpad
added
the
visual-test-ready
|
✔️ Dialtone Deploy Preview ready! |
|
✔️ Dialtone-vue 2 Deploy Preview ready! |
|
✔️ Dialtone-vue 3 Deploy Preview ready! |
How will be solve this?, will create a ticket or..? |
iropolo
approved these changes
Dec 13, 2023
Yep there is already one created by QA. I will do the fix. |
juliodialpad
pushed a commit
that referenced
this pull request
Dec 13, 2023
## [2.106.2](dialtone-vue2/v2.106.1...dialtone-vue2/v2.106.2) (2023-12-13) ### Bug Fixes * **Callbox:** correct color on voice chat icon ([#52](#52)) ([50defaf](50defaf)) * global lint ([#47](#47)) ([8148de3](8148de3)) * linter errors, add global lint command ([7ff09ea](7ff09ea)) ### Documentation * fix links, fix outdated documentation. ([#40](#40)) ([124082e](124082e))
|
🎉 This PR is included in version 3.98.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The voice chat icon color on the new designs was supposed to be purple but it was set as green. Correcting this, will require a small change in product as well due to the slot in callbox.
Pull Request Checklist
stagingas your pull request's base branch. (All PRs usingproductionas its base branch will be declined).gulpscripts successfully compile.Obligatory GIF (super important!)