Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tokens): DLT-2135 fix remaining iOS issues #535

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(tokens): DLT-2135 fix remaining iOS issues #535

merged 1 commit into from
Oct 22, 2024

Conversation

braddialpad
Copy link
Contributor

fix(tokens): DLT-2135 fix remaining iOS issues

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2135

📖 Description

  • Removed linear gradient values from android / ios
  • Changed value from .8 to 0.8 for iOS compatibility
  • Fixed iOS font stack transform that needed to be transitive
  • Fixed untransformed shadow color that must have been missed in francis' prior PR.

💡 Context

Couple of follow up fixes to https://dialpad.atlassian.net/browse/DLT-2135 to get the iOS tokens syntax correct again.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

🔮 Next Steps

Let Trevor know the fix is in, and to try it out.

🔗 Sources

https://styledictionary.com/

@braddialpad braddialpad added the no-visual-test Add this tag when the PR does not need visual testing label Oct 21, 2024
@braddialpad braddialpad self-assigned this Oct 21, 2024
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-535/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-535/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-535/

@ninamarina
Copy link
Contributor

Hi @braddialpad which tokens are affected by this and how can I test it?

@braddialpad
Copy link
Contributor Author

Need to run nx build within packages/dialtone-tokens and check the output of the file packages/dialtone-tokens/dist/ios/tokens-base-light.swift and tokens-dp-light.swift.

Should no longer be any syntax errors which previously were

  • usage of .8 rather than 0.8.
  • linear-gradient() which is not valid in swift.
  • The expressive font-family was previously Archivo, UIFont.systemFont(ofSize: 15), it should now just be UIFont.systemFont(ofSize: 15)

ninamarina
ninamarina reviewed Oct 22, 2024
View reviewed changes
packages/dialtone-tokens/build-sd-transforms.js
@@ -160,7 +160,6 @@ export async function run () {
},
android_compose: {
transforms: [
'ts/resolveMath',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor Author

@braddialpad braddialpad Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only supported in javascript/css. I think I put it in there previously to see if it would work on android and then forgot to remove it.

ninamarina
ninamarina approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@ninamarina ninamarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the generated tokens look correct. I only left a question

@braddialpad braddialpad merged commit 8dd82d1 into staging Oct 22, 2024
8 of 10 checks passed
@braddialpad braddialpad deleted the fix/ios-tokens branch October 22, 2024 20:12
juliodialpad pushed a commit that referenced this pull request Oct 30, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.80.0
c17727a 
# [9.80.0](dialtone/v9.79.3...dialtone/v9.80.0) (2024-10-23)

### Bug Fixes

* **Tokens:** DLT-2135 fix remaining iOS issues ([#535](#535)) ([8dd82d1](8dd82d1))

### Features

* **Combobox Multi Select:** DLT-1811 add pass thorugh props to style input ([#534](#534)) ([126d1fc](126d1fc))
* **Icon:** DLT-2166 update zendesk icon color ([#537](#537)) ([6e41aa6](6e41aa6))
juliodialpad pushed a commit that referenced this pull request Oct 30, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-tokens/v1.36.8
7e9c15a 
## [1.36.8](dialtone-tokens/v1.36.7...dialtone-tokens/v1.36.8) (2024-10-23)

### Bug Fixes

* **Tokens:** DLT-2135 fix remaining iOS issues ([#535](#535)) ([8dd82d1](8dd82d1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamarina ninamarina ninamarina approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

Assignees

@braddialpad braddialpad

Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braddialpad @ninamarina