Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync figma tokens #93

Merged
merged 2 commits into from
Jan 12, 2024
Merged

chore: sync figma tokens #93

merged 2 commits into from
Jan 12, 2024

Conversation

juliodialpad
Copy link
Collaborator

WIP - Sync figma tokens script and workflows

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1471

📖 Description

💡 Context

We're going to start syncing the tokens from dialtone-tokens with the figma variables and viceversa.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

🔮 Next Steps

  • Fix the sync scripts, this is a WIP still.
  • Add documentation.

@juliodialpad juliodialpad self-assigned this Jan 10, 2024
@juliodialpad juliodialpad added the no-visual-test Add this tag when the PR does not need visual testing label Jan 10, 2024
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-93/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-93/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-93/

@juliodialpad
Copy link
Collaborator Author

I'll merge this to staging so I can test the workflows as they're only workflow_dispatched. This shouldn't affect anything else.

@juliodialpad juliodialpad merged commit 9f98258 into staging Jan 12, 2024
10 of 11 checks passed
@juliodialpad juliodialpad deleted the sync-figma-tokens branch January 12, 2024 19:33
yorbi-dp pushed a commit that referenced this pull request Jan 18, 2024
* add sync script

* fix actions
emariotti3 pushed a commit that referenced this pull request Jan 19, 2024
* add sync script

* fix actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant