New eval and seed #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gym obs viz, fixed error in wrapper
alexpalms
force-pushed
the
newEvalAndSeed
branch
from
a80cdd9
to
73782ed
Compare
discordianfish
commented
Sep 4, 2022
discordianfish
commented
Sep 4, 2022
discordianfish
commented
Sep 4, 2022
diambra/arena/engine/interface.py
Outdated
| @@ -17,124 +17,173 @@ def __init__(self, env_address): | |||
| self.channel = grpc.insecure_channel(env_address) | |||
| self.stub = interface_pb2_grpc.EnvServerStub(self.channel) | |||
|
|
|||
| # Wait for grpc server to be ready | |||
| print("Trying to connect to DIAMBRA Engine server ...") | |||
There was a problem hiding this comment.
Can you use a proper logger for these things, eg https://docs.python.org/3/library/logging.html?
discordianfish
commented
Sep 4, 2022
| except grpc.FutureTimeoutError: | ||
| print("... failed.") | ||
| exceptionMessage = "DIAMBRA Arena failed to connect to the Engine Server." | ||
| print(exceptionMessage) |
There was a problem hiding this comment.
No need to print all these things if we raise an exception that prints this error anyway, right?
discordianfish
commented
Sep 4, 2022
discordianfish
commented
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.