Refactor/kotlinx.serialization #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlowMo7
reviewed
Jun 2, 2019
core/src/main/kotlin/com/tailoredapps/countriesexample/core/remote/RemoteModule.kt
Show resolved
Hide resolved
|
Does kotlinx.serialization have a better performance than Gson? Or why do you want to switch at all? |
|
In general I think if kotlin provides a standard way of serialisation and deserialisation, it should be used over a third party library like Gson. |
|
Improvement: Add an example for custom (de-)serialization (https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/custom_serializers.md) i.e. Dates |
FlowMo7
requested changes
Jun 6, 2019
| val regionalBlocs: List<RemoteRegionalBloc>, | ||
| val cioc: String | ||
| ) | ||
| val timezones: List<@ContextualSerialization ZoneOffset?> |
There was a problem hiding this comment.
Consider adding a nullable Serializer
…pecific Serializer class
…into refactor/kotlinx.serialization # Conflicts: # core/src/main/kotlin/com/tailoredapps/countriesexample/core/remote/serializer/ZoneOffsetSerializer.kt
FlowMo7
previously approved these changes
Jun 7, 2019
floschu
commented
Jun 7, 2019
core/src/main/kotlin/com/tailoredapps/countriesexample/core/remote/model/RemoteCountry.kt
Outdated
Show resolved
Hide resolved
| import org.threeten.bp.ZoneOffset | ||
|
|
||
| @ImplicitReflectionSerializer | ||
| class CustomSerializerTest : AutoCloseKoinTest() { |
curlyfrie
reviewed
Jun 14, 2019
| import org.threeten.bp.ZoneOffset | ||
|
|
||
| @Serializer(forClass = ZoneOffset::class) | ||
| object ZoneOffsetSerializer : KSerializer<ZoneOffset?> { |
floschu
added
the
don't merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Gson and instead added kotlinx.serialization