Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: add EditText and EditEmbed methods #66

Merged
merged 4 commits into from
May 15, 2020
Merged

API: add EditText and EditEmbed methods #66

merged 4 commits into from
May 15, 2020

Conversation

mavolin
Copy link
Contributor

@mavolin mavolin commented May 15, 2020

Closes #63.

api/message.go Outdated
// EditMessageComplex.
func (c *Client) EditMessage(
channelID, messageID discord.Snowflake, content string,
embed *discord.Embed, suppressEmbeds bool) (*discord.Message, error) {
embed discord.Embed, suppressEmbeds bool) (*discord.Message, error) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be kept as a pointer? This will break quite a few APIs, and making it a pointer allows for optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I didn't think that one through.

@diamondburned diamondburned merged commit 6f6cf2b into diamondburned:master May 15, 2020
@mavolin mavolin deleted the 63-edit branch May 15, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: add EditText and EditEmbed methods
2 participants