Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package sys #15

Closed
diamondburned opened this issue Jul 5, 2021 · 1 comment
Closed

Package sys #15

diamondburned opened this issue Jul 5, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@diamondburned
Copy link
Owner

The current method of generation leaves a lot of implementation types and functions around, such as Wrapper functions, while also bloating files up. Too many files and #includes also drag the compile time out, so it's not ideal.

A better approach to this would be to make girgen create a sys package inside pkg/internal/sys, which would contain implementation classes like a type GtkWidget struct as well as the wrapper function. This would not only clear up the documentation, it would also speed up compiling by having everything in one large file. Types could also embed other structs instead of having to embed the public interface, which would reduce class types' sizes to just 8 bytes.

@diamondburned
Copy link
Owner Author

After attempts in implementing this, a package sys is not feasible, because functions and constructors defined in the main package may have to import the sys package for types, while the sys package is definitely importing the main package for its type signatures.

Closing this issue, as it's not feasible to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant