Fix plots #728
Merged
Fix plots #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, return both fig and axs
SarahAlidoost
added
the
standup
SarahAlidoost
removed
the
standup
Merged
elboyran
reviewed
Apr 4, 2024
stefsmeets
approved these changes
Apr 8, 2024
|
[like] Elena Ranguelova reacted to your message:
…________________________________
From: Stef Smeets ***@***.***>
Sent: Monday, April 8, 2024 6:58:16 AM
To: dianna-ai/dianna ***@***.***>
Cc: Elena Ranguelova ***@***.***>; Mention ***@***.***>
Subject: Re: [dianna-ai/dianna] Fix plots (PR #728)
@stefsmeets approved this pull request.
—
Reply to this email directly, view it on GitHub<#728 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAYYBWLX3A4PRLVCJDXQ4VLY4I5YRAVCNFSM6AAAAABE53GUT2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBVGU4DCOJSGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks for reviewing, I addressed your comments. If the PR looks okay, can you approve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #713
and
closes #691
closes #696
closes #206
closes #716
I think this pull request will close all issues listed above. Reviewer please check it. Thanks 😊