add rise tabular #730
Merged
add rise tabular #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it would only confuse the user
cwmeijer
added this to In progress
in SS Sprint 8 - EO & EULAW usecases; big fixes and outreach
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cwmeijer
moved this from In progress
to Ready for review
in SS Sprint 8 - EO & EULAW usecases; big fixes and outreach
cwmeijer
moved this from In progress
to Ready for review
in SS Sprint 8 - EO & EULAW usecases; big fixes and outreach
cwmeijer
moved this from In progress
to Ready for review
in SS Sprint 8 - EO & EULAW usecases; big fixes and outreach
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
elboyran
reviewed
May 30, 2024
dianna/utils/maskers.py
Outdated
| p_keep: float, number_of_features: int): | ||
| def generate_time_step_masks(input_data_shape: tuple[int], | ||
| number_of_masks: int, p_keep: float, | ||
| number_of_features: int): | ||
| """Generate masks that masks complete time steps at a time while masking time steps in a segmented fashion. |
There was a problem hiding this comment.
It is a bit hard to understand.
There was a problem hiding this comment.
I updated the docstring. It's better now I think.
elboyran
reviewed
May 30, 2024
elboyran
requested changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #644, #712.
What works/is included:
How to test?