738 text lime in dashboard returns an error #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwmeijer
approved these changes
Jun 13, 2024
|
I added tests for images, text and timeseries, but encountered a problem with images KernelSHAP, see my updated PR comment above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #738
Lime runs into an error because of a typo in the variable name -> rand_state instead of random_state.
Additionally lime timeseries does not have this variable, which also returns an error, since the random_state variable is used in all LIME methods. Although random_state is not used in lime timeseries, adding the variable to the class fixes the issue.
Edit:
Added tests for dashboard text, image, and timeseries for LIME and KernelSHAP to complete the dashboard tests. It turned out that the dashboard was actually not working for images with KernelSHAP. I made changes in dashboard/_models_image.py to do this, but I am not sure of the changes are 100% correct. Can someone please check @cwmeijer @loostrum maybe?