This repository was archived by the owner on Oct 19, 2022. It is now read-only.
fix: respect pause and resume on connections #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm suspicious that without any 'unpipe', this will create errors when we have other streams writing to the conn stream after the handshake has been performed. How tested was this upgrade with swarm and secio tests? |
|
@diasdavid can you write a test for the concern you have? |
|
The best is to link it to swarm and make sure it passes all the tests cause there is a lot of writes coming from several places |
|
swarm + secio passes with this change, that's why I implemented it in the first place |
| lpm.write(conn, new Buffer(protocol + '\n')) | ||
| lpm.read(conn, function (msgBuffer) { | ||
| encode.write(new Buffer(protocol + '\n')) | ||
| decode.once('data', function (msgBuffer) { |
There was a problem hiding this comment.
ah, got it. 'once' and not 'on'
|
@dignifiedquire released on 0.10 |
|
thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@diasdavid please review and release when happy