Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to 48kHz on Windows #4459

Merged
merged 1 commit into from
Apr 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Source/options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,17 @@ namespace devilution {
#define DEFAULT_HEIGHT 480
#endif
#ifndef DEFAULT_AUDIO_SAMPLE_RATE
#if defined(_WIN64) || defined(_WIN32)
// The sound API used by SDL in Windows (WASAPI) isn't great
// at upsampling from 22050 Hz on some drivers.
//
// Upsample ourselves on Windows by default.
// See https://github.com/diasurgical/devilutionX/issues/1390
#define DEFAULT_AUDIO_SAMPLE_RATE 48000
#else
#define DEFAULT_AUDIO_SAMPLE_RATE 22050
#endif
#endif
#ifndef DEFAULT_AUDIO_CHANNELS
#define DEFAULT_AUDIO_CHANNELS 2
#endif
Expand Down