Fix Item Validation #6723
Merged
Fix Item Validation #6723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve spell book level validation
|
Note: I have not done any thorough testing in game to make sure this operates as intended. I can this upcoming weekend, however I would like to just put that out there that this needs to be reviewed with caution to ensure it's working as intended. |
StephenCWills
requested changes
Oct 18, 2023
StephenCWills
approved these changes
Oct 19, 2023
|
Maybe connected :?P , couldnt pick up book of apocalypse, and it sent some error packet message . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item validation was missing logic to consider container drops (which is problematic in Hellfire since the Crypt can drop ilvl 32 and 34 items). Also added documentation. Also we have been letting items that have the ilvl that matches the mlvl of Defiler and Na-Krul pass validation; This shouldn't happen because these monsters never drop items equal to their mlvl (Book of Apocalypse doesn't count, because the level of the book is derived from another formula, which coincedentally is 40).