blit_impl: Use <algorithm> with unseq policy #7115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
render-algorithm
branch
3 times, most recently
from
d0500ea
to
d06565a
Compare
AJenbo
approved these changes
Jun 9, 2024
|
Fixed my cooling solution and upgraded to 24.04 and now I'm also seeing an improvement: Before: 1380fps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my desktop with Ryzen 3950x, RTX 4080, Ubuntu 24.04, gcc 13.2.0, I get a consistent performance improvement with this PR, as measured by
tools/measure_timedemo_performance.py.Before: 7.722 ± 0.065 seconds, 949.090 ± 7.807 FPS
After: 6.733 ± 0.057 seconds, 1088.520 ± 8.710 FPS
Binary size is also decreased by ~350 KiB:
Before: 6007752
After: 5652488
RG99 binary size is only decreased by ~16 KiB, still a good thing.