Refactor: Check_Curs_Move (Issue: 1995) #7138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated for clang formatting and consistent reference variable syntax. |
AJenbo
force-pushed
the
master
branch
2 times, most recently
from
ac7aa1d
to
7dc5d90
Compare
AJenbo
previously approved these changes
Sep 22, 2024
AJenbo
previously approved these changes
Sep 22, 2024
|
Thanks, I did a bit extra refactoring to change the code to use Point rather then int pairs, this also removed some redundant code. |
AJenbo
previously approved these changes
Sep 22, 2024
AJenbo
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to address this issue link: #1995
Refactored lots of functionality out into helper functions in cursor.cpp, small tweaks, but no big change to logic
This is my first ever pull request, hoping to just get a bit of practice before I make a bigger contribution! (Tips and suggestions would be much appreciated)