Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect test for collisions in hash #662

Closed
jgluck opened this issue Nov 17, 2014 · 8 comments
Closed

Incorrect test for collisions in hash #662

jgluck opened this issue Nov 17, 2014 · 8 comments
Milestone

Comments

@jgluck
Copy link
Contributor

jgluck commented Nov 17, 2014

These two tests seem to be doing the same thing, while suggesting they are doing opposite things

Lines in question

Maybe there is a difference here, I just don't see it.

@mr-c
Copy link
Contributor

mr-c commented Nov 17, 2014

Thank you @jgluck for bringing this to our attention.

@ctb This predates me.

@ctb
Copy link
Member

ctb commented Nov 17, 2014

On Sun, Nov 16, 2014 at 10:15:47PM -0800, Michael R. Crusoe wrote:

Thank you @jgluck for bringing this to our attention.

@ctb This predates me.

It does indeed look like they're the same test, doesn't it? :)

@mr-c
Copy link
Contributor

mr-c commented Nov 20, 2014

Whoops, mea culpa.

@ctb I haven't tracked this through the Git history to see what was the intended or prior behaviour; thought you might rememeber.

@jgluck
Copy link
Contributor Author

jgluck commented Nov 20, 2014

Haha, yeah, sorry. This was a separate issue. I just didn't entirely understand the underlying structure enough to fix it and create a pull request.

@ctb ctb changed the title Incorrect Test Incorrect test for collisions in hash Nov 22, 2014
@ctb
Copy link
Member

ctb commented Nov 22, 2014

On Thu, Nov 20, 2014 at 09:55:11AM -0800, Michael R. Crusoe wrote:

Whoops, mea culpa.

@ctb I haven't tracked this through the Git history to see what was the intended or prior behaviour; thought you might rememeber.

Just delete it for now, I think.

@ctb
Copy link
Member

ctb commented Jul 18, 2015

Fix: remove test_no_collision() from test_counting_single.py -- https://github.com/dib-lab/khmer/blob/master/tests/test_counting_single.py#L19

@mr-c mr-c added this to the 2.0 milestone Jul 30, 2015
@bocajnotnef bocajnotnef mentioned this issue Aug 3, 2015
8 tasks
@bocajnotnef
Copy link
Contributor

Fix in #1220

@bocajnotnef
Copy link
Contributor

Closing #662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants