New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect test for collisions in hash #662
Comments
Whoops, mea culpa. @ctb I haven't tracked this through the Git history to see what was the intended or prior behaviour; thought you might rememeber. |
Haha, yeah, sorry. This was a separate issue. I just didn't entirely understand the underlying structure enough to fix it and create a pull request. |
On Thu, Nov 20, 2014 at 09:55:11AM -0800, Michael R. Crusoe wrote:
Just delete it for now, I think. |
Fix: remove test_no_collision() from test_counting_single.py -- https://github.com/dib-lab/khmer/blob/master/tests/test_counting_single.py#L19 |
Fix in #1220 |
Closing #662 |
These two tests seem to be doing the same thing, while suggesting they are doing opposite things
Lines in question
Maybe there is a difference here, I just don't see it.
The text was updated successfully, but these errors were encountered: