Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant test #1220

Merged
merged 1 commit into from Aug 4, 2015
Merged

Removed redundant test #1220

merged 1 commit into from Aug 4, 2015

Conversation

bocajnotnef
Copy link
Contributor

ref #662

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

diff-cover is clean locally.

@bocajnotnef
Copy link
Contributor Author

@ctb @mr-c Ready for merge

@ctb
Copy link
Member

ctb commented Aug 4, 2015

thx.

ctb added a commit that referenced this pull request Aug 4, 2015
@ctb ctb merged commit c95689e into master Aug 4, 2015
@ctb ctb deleted the fix/662 branch August 4, 2015 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants