Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _screed_record_dict calls in khmer #1066

Merged
merged 13 commits into from Jun 12, 2015
Merged

Rename _screed_record_dict calls in khmer #1066

merged 13 commits into from Jun 12, 2015

Conversation

ctb
Copy link
Member

@ctb ctb commented Jun 6, 2015

Fix issue #767; taken over from #956.

Added support for changes in screed - need to have correct screed version in order to work
Passes test when specifying the screed version.

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

Conflicts:
	ChangeLog
	scripts/trim-low-abund.py
@ctb
Copy link
Member Author

ctb commented Jun 6, 2015

Needs to wait for the next release of screed, sadly.

@ctb ctb added this to the 2.0 milestone Jun 6, 2015
@luizirber
Copy link
Member

I'm taking over this and bringing #1045 changes too.

(#1045 did this change, but there other fixes needed for screed 0.9)

@luizirber
Copy link
Member

OK, at this point both me and Titus touched the PR, so ready for review and merge @mr-c @camillescott

@mr-c
Copy link
Contributor

mr-c commented Jun 12, 2015

LGTM, thanks!

mr-c added a commit that referenced this pull request Jun 12, 2015
Rename _screed_record_dict calls in khmer
@mr-c mr-c merged commit 024ea89 into master Jun 12, 2015
@mr-c mr-c deleted the fix/767 branch June 12, 2015 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants