Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for scripts/find-knots.py & associated fix #1078

Merged
merged 2 commits into from Jun 10, 2015
Merged

Conversation

ctb
Copy link
Member

@ctb ctb commented Jun 10, 2015

Fixes #358.

@ctb
Copy link
Member Author

ctb commented Jun 10, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

Ready for review & merge @camillescott @luizirber

@luizirber
Copy link
Member

LGTM

luizirber added a commit that referenced this pull request Jun 10, 2015
Add test for scripts/find-knots.py & associated fix
@luizirber luizirber merged commit 964a423 into master Jun 10, 2015
@luizirber luizirber deleted the test/find-knot branch June 10, 2015 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants