Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabled running of test_normalize_by_median_report_fp during normal tests #1135

Merged
merged 5 commits into from Jul 1, 2015
Merged

disabled running of test_normalize_by_median_report_fp during normal tests #1135

merged 5 commits into from Jul 1, 2015

Conversation

ctb
Copy link
Member

@ctb ctb commented Jun 30, 2015

See #1123.

@ctb
Copy link
Member Author

ctb commented Jun 30, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

ready for review & merge @mr-c @camillescott @luizirber @bocajnotnef

@bocajnotnef
Copy link
Contributor

Shouldn't this be disabling test_normalize_by_median_report_fp in addition to/instead of test_normalize_by_median_fpr? For me the tests slow significantly when they hit report_fp, which makes sense since it takes the test-large as an arg.

@ctb ctb changed the title disabled running of test_normalize-by_median_report_fp during normal tests disabled running of test_normalize_by_median_report_fp during normal tests Jul 1, 2015
@ctb
Copy link
Member Author

ctb commented Jul 1, 2015

Whoops, fixed. tnx. Ready for review @bocajnotnef

@bocajnotnef
Copy link
Contributor

LGTM. Merging.

bocajnotnef added a commit that referenced this pull request Jul 1, 2015
@bocajnotnef
Merge pull request #1135 from dib-lab/fix/slowtest_disable
168b427 
disabled running of test_normalize_by_median_report_fp during normal tests
@bocajnotnef bocajnotnef merged commit 168b427 into master Jul 1, 2015
@ctb ctb mentioned this pull request Jul 19, 2015
Closed
@bocajnotnef bocajnotnef deleted the fix/slowtest_disable branch July 27, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctb @bocajnotnef