Feature/traversal small #1231
Merged
Feature/traversal small #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, test this please you useless piece of non-sentient AI filth |
|
CR plz @ctb @mr-c @luizirber @bocajnotnef |
| * khmer/_khmer.cc,lib/{counting,hashbits,hashtable,labelhash,subset}.{cc,hh}: | ||
| Updated relevant instances of HashIntoType and KMerIterator to use new Kmer | ||
| and KmerIterator, respectively. | ||
| * lib/Makefile: Add -std=c+=11 flag. |
…rching functionality under one Traverser class; adds a Kmer object to store hashed values and a KmerFactory to produce Kmers; updates Hashtable and KmerIterator to subclass KmerFactory; updates all existing traversal related functionality to use Traverser and KmerFactory, while removing tons of redundant code.
camillescott
force-pushed
the
feature/traversal_small
branch
from
65d8012
to
039e5cc
Compare
|
Looks great, thank you for the Doxygen docs! |
|
|
||
| public: | ||
|
|
||
| KmerFactory(WordLength K): _ksize(K) {} |
There was a problem hiding this comment.
Whoops, found another cppcheck warning:
Class 'KmerFactory' has a constructor with 1 argument that is not explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #1080.
Check for code coverage with
make clean diff-covermake pep8,make diff_pylint_report,make cppcheck, andmake docoutput. Usemake formatand manualfixing as needed.
without a major version increment. Changing file formats also requires a
major version number increment.
http://en.wikipedia.org/wiki/Changelog#Format
changes were made?