Coverage audit

[bocajnotnef]

Scanned through the coverage report on master. Am adding tests or deleting unreachable code.

[bocajnotnef]

Do we need the "debugging support" stuff in partition-graph? It never gets tested.

if "Linux" == platform.system():
    def __debug_vm_usage(msg):
        print("===> DEBUG: " + msg, file=sys.stderr)
        for vmstat in re.findall(r".*Vm.*", file("/proc/self/status").read()):
            print(vmstat, file=sys.stderr)
else:
    def __debug_vm_usage(msg):  # pylint: disable=unused-argument
        pass

https://github.com/dib-lab/khmer/blob/master/scripts/partition-graph.py#L32

[bocajnotnef]

Said debug code is also in do-partition.

[bocajnotnef]

• Is it mergeable?
• Did it pass the tests?
• If it introduces new functionality in scripts/ is it tested?
  Check for code coverage with make clean diff-cover
• Is it well formatted? Look at make pep8, make diff_pylint_report,
  make cppcheck, and make doc output. Use make format and manual
  fixing as needed.
• Did it change the command-line interface? Only additions are allowed
  without a major version increment. Changing file formats also requires a
  major version number increment.
• Is it documented in the ChangeLog?
  http://en.wikipedia.org/wiki/Changelog#Format
• Was a spellchecker run on the source code and documentation after
  changes were made?
• Is the Copyright year up to date?

[bocajnotnef]

@mr-c @luizirber Ready for merge

[bocajnotnef]

Considering adding #1225 in...

[ctb]

Do you want to get this in 2.0?

Titus Brown, ctbrown@ucdavis.edu

On Aug 9, 2015, at 2:19 PM, Jake Fenton notifications@github.com wrote:

Considering adding #1225 in...

—
Reply to this email directly or view it on GitHub.

[bocajnotnef]

Only if you want it there. I don't see it impacting userspace much so it's probably not necessary--just makes it easier for people developing.

[mr-c]

Please drop the partition-graph debugging code, yes.

[mr-c]

This LGTM, thanks!

[bocajnotnef]

retest this please