Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioneer 0.15+dev #1299

Merged
merged 4 commits into from
Jun 27, 2016
Merged

versioneer 0.15+dev #1299

merged 4 commits into from
Jun 27, 2016

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Sep 8, 2015

Includes fix for git describe .. --match

Fixes #1272
Could address #1280

Fixes issue with ReadTheDocs not willing to build the 'stable' release:
Before:
https://readthedocs.org/projects/khmer/builds/3307848/
After:
http://khmer.readthedocs.org/en/stable/

@mr-c
Copy link
Contributor Author

mr-c commented Sep 8, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)
  • Is the Copyright year up to date?

@mr-c
Copy link
Contributor Author

mr-c commented Sep 8, 2015

PR description updated: #1299 (comment)
@luizirber @camillescott @ctb Ready for review & merge

@mr-c mr-c added this to the 2.0+ milestone Sep 8, 2015
@mr-c
Copy link
Contributor Author

mr-c commented Oct 19, 2015

I've rebased; @luizirber @camillescott @ctb Ready for review & merge

@standage
Copy link
Member

Merging (8 months post facto :)

@standage standage merged commit 26503de into master Jun 27, 2016
@mr-c mr-c deleted the fix/versioneer branch June 27, 2016 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to latest versioneer release
2 participants