-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial null-o-mer script #1754
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 87 87
Lines 11451 11451
Branches 3078 3078
======================================
Hits 6 6
Misses 11445 11445 Continue to review full report at Codecov.
|
Only question: what is a null-o-mer? Was guessing "all kmers with a count of zero" but then it prints all of them. Otherwise LGTM. |
yes, what you thought. I'm asking the requestor what exact output they want.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge when ready @ctb
I am saddened by the failure of several different reviewers to test this code... tsk tsk. |
And the merge of a PR with none of the checkboxes ticked also seems problematic. tsk tsk. |
… On Thu, Aug 31, 2017, 5:05 PM C. Titus Brown ***@***.***> wrote:
And the merge of a PR with none of the checkboxes ticked also seems
problematic. tsk tsk.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1754 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAZ8i763bgibpp2-Q15QPdTc_-Q87-lks5sd0pVgaJpZM4OzSEo>
.
|
Requested by someone via e-mail; thought I'd add it to the examples.
Example output:
make test
Did it pass the tests?make clean diff-cover
If it introduces new functionality inscripts/
is it tested?make format diff_pylint_report cppcheck doc pydocstyle
Is it wellformatted?
additions are allowed without a major version increment. Changing file
formats also requires a major version number increment.
documented in
CHANGELOG.md
? See keepachangelogfor more details.
changes were made?
tested for streaming IO?)