Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial null-o-mer script #1754

Merged
merged 5 commits into from
Aug 31, 2017
Merged

initial null-o-mer script #1754

merged 5 commits into from
Aug 31, 2017

Conversation

ctb
Copy link
Member

@ctb ctb commented Aug 10, 2017

Requested by someone via e-mail; thought I'd add it to the examples.

Example output:

% python find-nullomers.py ~/dev/sourmash-tutorial/ecoliMG1655.fa.gz  | head
allocating lots of memory for exact counts: 4194304 bytes
consuming /Users/t/dev/sourmash-tutorial/ecoliMG1655.fa.gz
...done!
Iterating over all 11-mers
AAAAAAAAAAA 0
AAAAAAAAAAT 0
AAAAAAAAAAC 0
AAAAAAAAAAG 0
AAAAAAAAATA 3
AAAAAAAAATT 0
  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

@codecov-io
Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #1754 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1754   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files          87      87           
  Lines       11451   11451           
  Branches     3078    3078           
======================================
  Hits            6       6           
  Misses      11445   11445

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e175b...8185a86. Read the comment docs.

@betatim
Copy link
Member

betatim commented Aug 10, 2017

Only question: what is a null-o-mer? Was guessing "all kmers with a count of zero" but then it prints all of them.

Otherwise LGTM.

@ctb
Copy link
Member Author

ctb commented Aug 11, 2017 via email

Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when ready @ctb

@standage standage merged commit 38426ed into master Aug 31, 2017
@standage standage deleted the example/nullomers branch August 31, 2017 16:40
@ctb
Copy link
Member Author

ctb commented Sep 1, 2017

I am saddened by the failure of several different reviewers to test this code... tsk tsk.

@ctb
Copy link
Member Author

ctb commented Sep 1, 2017

And the merge of a PR with none of the checkboxes ticked also seems problematic. tsk tsk.

@luizirber
Copy link
Member

luizirber commented Sep 1, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants