Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hash table write error alert. #411

Merged
merged 1 commit into from
May 31, 2014
Merged

Adds hash table write error alert. #411

merged 1 commit into from
May 31, 2014

Conversation

znruss
Copy link
Contributor

@znruss znruss commented Apr 28, 2014

Writing can silently fail on certain systems (like mine). I don't know how to prevent it, but here's a few lines to add in error alerts.

Writing can silently fail on certain systems (like mine).  I don't know how to prevent it, but here's a few lines to add in error alerts.
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@ctb
Copy link
Member

ctb commented Apr 29, 2014

jenkins, please test this.

@mr-c
Copy link
Contributor

mr-c commented May 7, 2014

test this please

@mr-c
Copy link
Contributor

mr-c commented May 7, 2014

Can one of the admins verify this patch?

@mr-c
Copy link
Contributor

mr-c commented May 7, 2014

ok to test

@mr-c
Copy link
Contributor

mr-c commented May 7, 2014

handing back to @ctb to consider

  • Is it mergable
  • Did it pass the tests?
    N/A If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 if needed.
  • Is it documented in the Changelog?

@mr-c
Copy link
Contributor

mr-c commented May 30, 2014

@znruss Does #333 address your needs?

@ctb
Copy link
Member

ctb commented May 31, 2014

After looking at this, it seems like an OK addition to add write error human-readable output. It's obviously not the long-term fix, though (see #443 for that). @mr-c, what do you think?

@mr-c
Copy link
Contributor

mr-c commented May 31, 2014

Sure, this is fine for now. I'll check it over and merge it in.

mr-c added a commit that referenced this pull request May 31, 2014
Adds hash table write error alert.
@mr-c mr-c merged commit fbc307a into dib-lab:master May 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants