Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C++ writing code to handle write exceptions properly. #443

Closed
ctb opened this issue May 31, 2014 · 3 comments · Fixed by #856
Closed

Update C++ writing code to handle write exceptions properly. #443

ctb opened this issue May 31, 2014 · 3 comments · Fixed by #856

Comments

@ctb
Copy link
Member

ctb commented May 31, 2014

Like #333, but for writing. Subsumes #95 and #246. Would address #411.

@mr-c
Copy link
Contributor

mr-c commented Sep 1, 2014

@ctb Is this issue fixed?

@ctb
Copy link
Member Author

ctb commented Dec 28, 2014

Issue not fixed -- we need to transmute exceptions from the C++ layer into khmer exceptions, and then transfer them into Python exceptions. So, for example, hash_save in khmer/_khmermodule.cc should check for a C++ exception, and CountingHashFile::save in counting.cc needs to catch write errors. And then of course we need some tests.

@mr-c
Copy link
Contributor

mr-c commented Dec 28, 2014

There is a first stab at this in #704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants