Start of issue 718, file not existing clean up

[jessicalumian]

Fix for #718.

[jessicalumian]

• Is it mergable?
• Did it pass the tests?
• If it introduces new functionality in scripts/ is it tested?
  Check for code coverage.
• Is it well formatted? Look at make pep8, make diff_pylint_report,
  make cppcheck, and make doc output. Use make format and manual
  fixing as needed.
• Did it change the command-line interface? Only additions are allowed
  without a major version increment. Changing file formats also requires a
  major version number increment.
• Is it documented in the ChangeLog?
• Was a spellchecker run on the source code and documentation after
  changes were made?

[jessicalumian]

Can 2 people please review this code? @b-wyss @bocajnotnef @brtaylor92

[bocajnotnef]

Looks good to me minus the non-mergable status.

[b-wyss]

Looks good to me as well, unless you want to change existance to existence? Totally up to you, but the rest looks okay!

[ctb]

unnecessary empty line ;)

[jessicalumian]

@ctb could you remind me of the idea behind the if/if not statement to be put here you mentioned today?

[ctb]

You could rewrite it as:

check_file_status_exited = False
try:
    check_file_status(fn, False)
except SystemExit:
    check_file_status_exited = True

assert check_file_status_exited

which makes the logic clear, at least.

[jessicalumian]

@mr-c has the compatibility problem with pep8/autopep8 been fixed?

[mr-c]

Yes, sorry. Update to the latest from the master branch and you should be
good to go.

On Fri, Mar 13, 2015, 14:38 jessicamizzi notifications@github.com wrote:

@mr-c https://github.com/mr-c has the compatibility problem with
pep8/autopep8 been fixed?

—
Reply to this email directly or view it on GitHub
#772 (comment).

[mr-c]

Thanks!