Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set 'force' to default to False on kfile.check_file_status. #849

Closed
wants to merge 1 commit into from
Closed

set 'force' to default to False on kfile.check_file_status. #849

wants to merge 1 commit into from

Conversation

ctb
Copy link
Member

@ctb ctb commented Feb 25, 2015

minor fix for some sandbox scripts, but I think this is a good default for this function.
#772 should test for this - I don't want to step all over @jessicamizzi's code :)

@ctb
Copy link
Member Author

ctb commented Feb 25, 2015

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Member Author

ctb commented Feb 25, 2015

Ready for review & merge @jessicamizzi @mr-c @luizirber @camillescott

mr-c
mr-c reviewed Feb 25, 2015
View reviewed changes
ChangeLog
@@ -6,6 +6,11 @@
* tests/test_scripts.py: add a test for the --append option in
normalize-by-median.py

2015-02-25 Titus Brown <titus@idyll.org>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New entries go to the top of the Changelog please

@ctb
Copy link
Member Author

ctb commented Feb 25, 2015

Yeah, I thought that might have been your evil plan.

@ctb ctb closed this Feb 25, 2015
@ctb ctb mentioned this pull request Feb 25, 2015
Merged
@mr-c mr-c deleted the update/force_arg branch March 6, 2015 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctb @mr-c