Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Record changes that break with khmer 2.0 #64

Merged
merged 2 commits into from Jan 21, 2017
Merged

Revert Record changes that break with khmer 2.0 #64

merged 2 commits into from Jan 21, 2017

Conversation

ctb
Copy link
Member

@ctb ctb commented Dec 24, 2016 •
edited

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality, is it tested?
  • make format diff_pylint_report doc Is it well formatted?
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Dec 24, 2016 •
edited

Current coverage is 80.40% (diff: 100%)

No coverage report found for master at d0b4a53.

Powered by Codecov. Last update d0b4a53...13b54cc

@betatim betatim mentioned this pull request Jan 2, 2017
Closed
@ctb ctb mentioned this pull request Jan 21, 2017
Merged
8 tasks
@ctb
Copy link
Member Author

ctb commented Jan 21, 2017

This is ready for review and merge.

standage
standage approved these changes Jan 21, 2017
View reviewed changes
Copy link
Member

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@standage standage merged commit 2192292 into master Jan 21, 2017
@standage standage deleted the revert/read branch January 21, 2017 15:10
@betatim betatim mentioned this pull request Jan 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@standage standage standage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctb @codecov-io @standage