Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caddy configuration guide #74

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Add caddy configuration guide #74

merged 7 commits into from
Sep 10, 2024

Conversation

vt-d
Copy link
Contributor

@vt-d vt-d commented May 5, 2024

No description provided.

Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zipline-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 6:40am

Copy link
Owner

@diced diced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the caddy directory only has one file, you do not need to create a category.json and it's own directory. You can just move the Caddy Reverse Proxy.md to the docs/guides/caddy.md.

@diced
Copy link
Owner

diced commented Sep 9, 2024

I think it would be better actually to create a new "Reverse Proxies" group, and then placing nginx and caddy in there, if you don't mind doing that. I also think that the comments within the code block should be on the line above instead of on the same line, since it causes the reader to have to scroll horizontally which can be annoying sometimes

Copy link
Owner

@diced diced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i'll just do it later when i'm changing up other stuff, ty for the pr

@diced diced merged commit 0b53a2c into diced:trunk Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants