Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argparse #648

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Argparse #648

merged 1 commit into from
Aug 30, 2023

Conversation

Jason2605
Copy link
Member

@Jason2605 Jason2605 commented Aug 29, 2023

Argparse

What's Changed:

This PR updates the Argparse builtin with the following changes:

  • Allows negative numbers to be input on addNumber
  • Mark user defined usage as optional when creating the Parser object
  • Add parser.usage() to docs
  • Make any non-required option that is not filled in be null
    • Rationale for this is it will reduce boilerplate of having to .getAttrbibute() rather than just if (!args.<arrg>)
  • Mark preArgs and required as instance variables for the (probably very rare) occasion that we want multiple Parser objects
  • Display if the argument is required in usage

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

@Jason2605 Jason2605 self-assigned this Aug 29, 2023
@briandowns
Copy link
Contributor

LGTM!

@Jason2605 Jason2605 merged commit d7e05d7 into develop Aug 30, 2023
8 checks passed
@Jason2605 Jason2605 deleted the feature/args branch August 30, 2023 16:55
This was referenced Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants