Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slide should update its currentPageIndex value when initialIndex value changed #278

Closed
tinymins opened this issue Aug 10, 2018 · 1 comment
Closed

Slide should update its currentPageIndex value when initialIndex value changed #278

tinymins opened this issue Aug 10, 2018 · 1 comment

Comments

@tinymins
Copy link

Version

1.10.10

Reproduction link

https://codesandbox.io/s/jzy76zjroy

Steps to reproduce

Change slide's initialIndex in page's mounted method.

What is expected?

Slide will init with new initialIndex value which was set in mounted

What is actually happening?

Slide still use the default initialIndex value in data()

Dependencies Version

vue: 2.5.17
better-scroll: 1.12.0

I've created a PR, just with one line added to solve this problem.
@tinymins tinymins mentioned this issue Aug 10, 2018
Closed
3 tasks
dolymood added a commit that referenced this issue Aug 21, 2018
@dolymood
fix(slide): update currentIndex in scrollEnd handler
ef91b40 
#278
@dolymood
Copy link
Contributor

1.10.11 fixed this issue

hu0950 pushed a commit that referenced this issue Nov 1, 2019
@dolymood
fix(slide): update currentIndex in scrollEnd handler
809153b 
#278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tinymins @dolymood