You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for this awesome UI components library, it is very handy and easy to use.
However, I need to be able to put custom icons/images as elements in the picker (I am building a card game where you may select the type of card, for example spades or hearths). Since there is only text rendering in the picker, I made in this PR the simplest changes to be able to handle dynamic HTML string templates rather than just text, which would solve my issue. See below for the details.
Changed the text rendering mode in the picker component,
From:
Using innerText rendering with <li>{{...}}</li>
To:
Using innerHTML rendering with <li v-html="..."></li>
This does not change anything for text items, but allows to insert HTML templates, especially icons and all the tests seem to be ok.
Changed the text rendering mode in the picker component,
From:
using innerText rendering with <li>{{...}}</li>
To:
using innerHTML rendering with <li v-html="..."></li>
This does not change anything for text items, but allows to insert HTML templates, especially icons.
All the tests seem to be ok.
Thanks for your PR.
It's very happy to hear that cube is handy for you. we are a little afraid that our poor english doc will be hard to read. Thanks again, and really looks forward to your next PR~~ 😄
Thank you very much, this really enables the picker to be more suitable for custom icons and helps me with my app :-)
When I have some left time I ll be glad to see if I can give you guys a hand, with the english why not haha
Cheers
hu0950
pushed a commit
that referenced
this pull request
Nov 1, 2019
Changed the text rendering mode in the picker component,
From:
using innerText rendering with <li>{{...}}</li>
To:
using innerHTML rendering with <li v-html="..."></li>
This does not change anything for text items, but allows to insert HTML templates, especially icons.
All the tests seem to be ok.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for this awesome UI components library, it is very handy and easy to use.
However, I need to be able to put custom icons/images as elements in the picker (I am building a card game where you may select the type of card, for example spades or hearths). Since there is only text rendering in the picker, I made in this PR the simplest changes to be able to handle dynamic HTML string templates rather than just text, which would solve my issue. See below for the details.
Changed the text rendering mode in the picker component,
From:
<li>{{...}}</li>To:
<li v-html="..."></li>This does not change anything for text items, but allows to insert HTML templates, especially icons and all the tests seem to be ok.
Thanks for your consideration,
Cheers,
NikolaLohinski