feat: view组件支持配置text相关属性 & border-radius 属性值支持% #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yandadaFreedom
changed the title
hiyuki
reviewed
Sep 5, 2024
| }, {}) | ||
| } | ||
|
|
||
| function splitProps(props: ExtendedViewStyle) { |
There was a problem hiding this comment.
props: ExtendedViewStyle 类型声明错了吧
hiyuki
reviewed
Sep 5, 2024
| const onLayout = () => { | ||
|
|
||
| nodeRef.current?.measure((x: number, y: number, width: number, height: number, offsetLeft: number, offsetTop: number) => { | ||
| layoutRef.current = { x, y, width, height, offsetLeft, offsetTop } | ||
| const newWidthStyleMap = percentTransform(widthRelativeStyleProps, 'width', { width }) |
hiyuki
reviewed
Sep 6, 2024
| children = [<Text key='viewTextWrap' style={textStyle}>{children}</Text>] | ||
| if (every(children as ReactNode[], (child) => isText(child))) { | ||
| if (textStyle || textProps) { | ||
| children = [<Text key='viewTextWrap' style={textStyle} {...(textProps || {})}>{children}</Text>] |
hiyuki
approved these changes
Sep 6, 2024
added 3 commits
September 6, 2024 19:25
…nto fix-rn-base-component
hiyuki
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.