Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection list #35

Closed
diego3g opened this issue Jul 7, 2020 · 3 comments
Closed

Connection list #35

diego3g opened this issue Jul 7, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone
v1.0.0

Comments

@diego3g
Copy link
Owner

diego3g commented Jul 7, 2020

It should be able to connect to a save connection to see its details like how many keys are stored inside of each included databases.

The user may connect just by double clicking the connection inside the connection list on the sidebar.

After that, a loading indicator should be shown during the connection process and after all that the user will get a visual feedback about the connection status.

Red background: Connection failed
Purple background: Connection successful

If the connection fails, the user can retry it clicking a button, otherwise, the user can see all of the databases inside the connection and how many keys there are inside of each one.

Layout: https://www.figma.com/file/YRor24p0TmTxcjl5L86jGb/Rocket-Redis?node-id=1%3A2
@diego3g diego3g added the enhancement New feature or request label Jul 7, 2020
@diego3g diego3g added this to the v1.0.0 milestone Jul 7, 2020
@natanaelsirqueira
Copy link
Contributor

natanaelsirqueira commented Jul 14, 2020 •
edited
Loading

Hi @diego3g. Nice work so far!

Is this blocked by #34? Because I already gave it a try and started to prepare the layout for this feature.

@diego3g
Copy link
Owner Author

diego3g commented Jul 15, 2020

@natanaelsirqueira That's great to hear! I forgot to mention but i also started creating the connection list component and it's almost done.

I'll send a PR right now so you can review if there is something i forgot or that you done better, alright?

diego3g added a commit that referenced this issue Jul 15, 2020
@diego3g
feat(connection list): list connection databases and store current co…
1ece4f9 
…nnection/database

Currently, the user wasn't able to connect to a database and the current connection and database
weren't stored in the application state.

Now the user can connect to the saved connections in the
sidebar and list the databases inside the connection. The user can also connect to a single
database.

fix #34, fix #35
@natanaelsirqueira
Copy link
Contributor

@diego3g No problem at all! I learned something new today, that's what matters. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@diego3g @natanaelsirqueira