Pass ninja path to CMakeCache through CMAKE_MAKE_PROGRAM
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninja path is now passed systematically to CMake as its value changes when new virtual environments are created.
|
Awesome, thanks @remy-phelipot for the fix! Merging. If you want to install an updated version of |
diegoferigo
changed the title
CMAKE_MAKE_PROGRAM
|
Thanks for the quick integration! |
iguessthislldo
added a commit
to iguessthislldo/pyopendds
that referenced
this pull request
Mar 30, 2022
OpenDDS/OpenDDS#3315 changed where generated files are placed. Will need probably need long term solution. Also: - Workaround diegoferigo/cmake-build-extension#29 - Clarify apparent issue in OpenDDS#39
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ninja path is now passed systematically to CMake as its value changes when new
virtual environments are created.
Fix #26