Implemented cache busting for better experience for developers and users #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #7 diff @@
===================================
Files 29 29
Lines 187 187
Methods 32 32
Messages 0 0
Branches 48 48
===================================
Hits 187 187
Misses 0 0
Partials 0 0
|
diegohaz
requested changes
Oct 26, 2016
| @@ -4,6 +4,7 @@ var webpack = require('webpack') | |||
| var ip = process.env.IP || '0.0.0.0' | |||
| var port = process.env.PORT || 3000 | |||
| var DEBUG = process.env.NODE_ENV !== 'production' | |||
| var HtmlWebpackPlugin = require('html-webpack-plugin'); | |||
There was a problem hiding this comment.
Please, place this line at the top (after other requires) and remove the semicolon.
| }), | ||
| new HtmlWebpackPlugin({ | ||
| filename: 'index.html', | ||
| template: __dirname + '/public/index.html', |
|
Also, please, add |
|
sure. Done... |
diegohaz
approved these changes
Oct 26, 2016
|
Thank you ❤️ 👍 |
diegohaz
pushed a commit
that referenced
this pull request
Oct 26, 2016
…ers (#7) * Implemented cache busting for better experience for developers and users * Cleaned a bit * Added html-webpack-plugin to package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cache busting so that generated js filenames are now unique an automatically added to index.html