Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release packages #1856

Merged
merged 1 commit into from
Jun 7, 2022
Merged

chore: release packages #1856

merged 1 commit into from
Jun 7, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 4, 2022 •
edited

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@react-pdf/layout@3.1.0

Minor Changes

Patch Changes

@react-pdf/pdfkit@2.3.0

Minor Changes

Patch Changes

  • #1865 24f5c77 Thanks @diegomura! - feat: add background color and border with Note support

  • Updated dependencies [89b8059]:

    • @react-pdf/fontkit@2.1.1

@react-pdf/render@3.1.0

Minor Changes

Patch Changes

@react-pdf/renderer@2.2.0

Minor Changes

Patch Changes

@react-pdf/stylesheet@3.1.0

Minor Changes

Patch Changes

@react-pdf/types@2.1.0

Minor Changes

@react-pdf/fontkit@2.1.1

Patch Changes

@github-actions github-actions bot force-pushed the changeset-release/master branch 12 times, most recently from 5acc3d7 to 4d9f6d0 Compare June 6, 2022 05:37
@jeetiss
Copy link
Collaborator

jeetiss commented Jun 6, 2022

Wow @diegomura you made a lot of features here, nice

I see that you mentioned me as a reviewer in one PR, but I was late
I recheck all stuff that you made it looks incredible and I have a couple of improvements here

this should be a major change because it changes the folder structure to one file and the imports like @react-pdf/render/lib/** would not work after release

the PR with tweaks

ps. what do you think about changsets and the new way to release with PR and weird files in .changeset folder?)

@diegomura
Copy link
Owner

diegomura commented Jun 6, 2022 •
edited

Thanks @jeetiss ! I'd love any review in some of the new stuff, but no pressure at all 😄 It's hard to find time outside full time work. Since I don't have many lately I try to move fast and merge, but maybe I missed something along the way. I'd love to hear your thoughts

this should be a major change because it changes the folder structure to one file and the imports like @react-pdf/render/lib/** would not work after release

Good point. I did it minor since there weren't breaking changes in terms of the API. I can understand why that one might be breaking, but importing from /lib wasn't something "officially supported", just something it worked.

ps. what do you think about changsets and the new way to release with PR and weird files in .changeset folder?)

I love it! Yeah, folder is weird, but publishing everything by just clicking a merge button pays off. And not having to go through the list of all changes to decide what's major/minor/patch, and having to write changelogs manually. It's a game changer

Thanks for your PRs! I'll get into them asap!

@diegomura diegomura mentioned this pull request Jun 6, 2022
Merged
@diegomura diegomura merged commit ac3d81b into master Jun 7, 2022
@diegomura diegomura deleted the changeset-release/master branch June 7, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeetiss @diegomura