Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bookmarks support #1862

Merged
merged 3 commits into from
Jun 5, 2022
Merged

feat: bookmarks support #1862

merged 3 commits into from
Jun 5, 2022

Conversation

diegomura
Copy link
Owner

Add bookmarks support. Bookmarks can be added by the bookmark prop on any component. Prop value can be either

  • String, defining the bookmark title
  • Object, with the following keys
    • title: mandatory. Bookmark title
    • top: optional. x coordinate to redirect bookmark. defaults to element top coordiante
    • left: optional. y coordinate to redirect bookmark. defaults to element left coordinate
    • fit: optional. redirect bookmark to page (0,0) coordinate
    • zoom: optional. change zoom on bookmark redirect
    • expanded. optional. all of that section's children will be visible by default

Fixes #237

@diegomura diegomura requested a review from jeetiss June 5, 2022 00:32
@diegomura diegomura merged commit 1411d16 into master Jun 5, 2022
@diegomura diegomura deleted the dm/bookmarks branch June 5, 2022 19:22
@github-actions github-actions bot mentioned this pull request Jun 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeetiss jeetiss Awaiting requested review from jeetiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It can make bookMarks?
1 participant
@diegomura