DIP16 Draft: Transaction Scripts #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
requested review from
tnowacki,
tzakian,
runtian-zhou,
vgao1996,
wrwg,
bob-wilson and
meng-xu-cs
bob-wilson
reviewed
Mar 25, 2021
davidiw
reviewed
Apr 9, 2021
| Both script functions and the single function in a transaction script bytecode file have the following restrictions. For a function` f<ability_params>(param_types): ret_types` : | ||
|
|
||
| * The `ret_types` list is empty (i.e., the function does not return a value) | ||
| * The `param_types` list begins with one or more `signer` types |
There was a problem hiding this comment.
can you point to signer types?
Comment on lines
+54
to
+56
| module: ModuleId, | ||
| function: Identifier, | ||
| ty_args: Vec<TypeTag>, |
There was a problem hiding this comment.
are these defined anywhere? can we point to them?
There was a problem hiding this comment.
They are all defined in move-core-types. I'll add a note below.
| pub struct Script { | ||
| code: Vec<u8>, | ||
| ty_args: Vec<TypeTag>, | ||
| args: Vec<TransactionArgument>, |
There was a problem hiding this comment.
can you point to TransactionArgument?
Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>
This is (I think, but am not sure) how we agreed to document which parts of a DIP apply to which versions of Diem. Here, it's a bit awkward because the DIP didn't exist before Diem v1, but it is describing both v1 and v2 features. Definitely open to a different way of conveying this information if we can all standardize on it. |
davidiw
reviewed
May 11, 2021
| ### Changing script functions | ||
|
|
||
| * The name and type signature of an existing script function will never be changed. | ||
| * The set of error codes that may be returned by a script function is included in the [developer documentation](https://github.com/diem/diem/blob/main/language/diem-framework/transaction_scripts/doc/transaction_script_documentation.md) for each script. The error codes returned by a script function may grow or shrink, but the meaning of a given error code will remain fixed. E.g.: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.