DIP 161 Optional Result Field #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CapCap
reviewed
Apr 8, 2021
CapCap
reviewed
Apr 8, 2021
davidiw
previously requested changes
Apr 9, 2021
|
I don't think there's any big blockers here, but hit me up or dismiss review so we can get it in |
xli
reviewed
Apr 13, 2021
xli
reviewed
Apr 13, 2021
davidiw
previously requested changes
Apr 14, 2021
dips/dip-161.md
Outdated
Comment on lines
43
to
51
|
|
||
| **CommandResultObject:** | ||
|
|
||
| | Field | Type | Required? | Description | | ||
| |------- |------ |----------- |------------- | | ||
| | _ObjectType | str | Y | Type of command result object that uniquely defines the shape or other fields within the result | | ||
| | recipient_address | str | N | Receiver's on-chain address | | ||
|
|
||
| Other result types may be added if there are other use cases for the result field. |
There was a problem hiding this comment.
I would argue we don't need to define this and should leave delete this
Suggested change
| **CommandResultObject:** | |
| | Field | Type | Required? | Description | | |
| |------- |------ |----------- |------------- | | |
| | _ObjectType | str | Y | Type of command result object that uniquely defines the shape or other fields within the result | | |
| | recipient_address | str | N | Receiver's on-chain address | | |
| Other result types may be added if there are other use cases for the result field. |
xli
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding DIP 161: optional result field in off-chain protocol as defined in this issue #161