Initial draft of Dip 172: P2M On-Chain Registration #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidiw
approved these changes
May 18, 2021
| --- | ||
| dip: 172 | ||
| title: P2M (eCommerce) On-Chain Registration | ||
| authors: Dimitri Roche (@dimroc), David Wolinsky (@davidw), Yinon Zohar, Daniel Prinz |
There was a problem hiding this comment.
add everyone's github handle, we should be consistent about that
| authors: Dimitri Roche (@dimroc), David Wolinsky (@davidw), Yinon Zohar, Daniel Prinz | ||
| status: Draft | ||
| type: Standard | ||
| created: 05/14/2021 |
There was a problem hiding this comment.
add updated: https://dip.diem.com/dip-0/#updated-header
Comment on lines
+33
to
+35
|  | ||
|
|
||
|  |
There was a problem hiding this comment.
add these to the static file once they stabilize and look at DIP-1 for how to embed an image though I think its fine if we just point to the entry in the github repo.
| ```rust | ||
| resource struct CustomerVASPConfig { | ||
| enabled: bool, | ||
| authentication_url: vector<u8>, // UTF-8 encoded string |
There was a problem hiding this comment.
we should evaluate if we want to merge the two urls and add expected suffixes
| #### Field definitions: | ||
| * `enabled` -- defines whether or not the VASP is currently supporting P2M checkout. The intent here is that the customer experience should be seamless and not require awkward checks between the merchant VASP and customer VASP to validate whether or not the customer VASP supports merchant checkout. If this is false or the CustomerVASPConfig does not exist, then the customer VASP does not support checkout. | ||
| * `authentication_url` -- an endpoint that provides an authentication and authorization flow for the customer, the expected format is defined in [DIP-158’s appendix](https://github.com/diem/dip/blob/main/dips/dip-158.md#appendix-a---prerequisite-sharing-common-payment-identifier-and-address) | ||
| * `image_url` -- an endpoint that points to a standard image type (png, jpeg, gif) and is expected to be no larger than 100 KB (or maybe 10 KB?, the merchant or merchant VASP can always resize larger images to be smaller). |
There was a problem hiding this comment.
might want to move discussions like this to the issue (what size should we recommend)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write up of the Customer VASP registration step, including on-chain structs and events.