Fix Transaction Details Page #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkollasch-vmware
suggested changes
Dec 8, 2021
There was a problem hiding this comment.
I'm concerned about the loss of the human-readable currency code, but I don't have enough context to suggest an alternative. Let's get @ankushagarwal's opinion.
mkollasch-vmware
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Blockchain JSONRPC integration broke which broke the Transaction details page.
We have a tech-debt item to deprecate the JSONRPC API with the new REST API.
Since this page was the last user of the old API I made the switch :)