-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate summary update review report to comment on PR #107
Conversation
26bf1a0
to
29fb10d
Compare
Github comments support markdown + some other fancy html things so it would probably be good to leverage that. For example the list of files with unsafe isn't very readable atm, it would probably be better if you were able to use an expandable list for that: Modified files which contain unsafe
src/lib.rs
It also has some support for tables, for example you can take a look at bor's help output: |
Bors help and documentationBors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's General
CommandsBors actions can be triggered by posting a comment which includes a line of the form
OptionsOptions for Pull Requests are configured through the application of labels. |
You could also use emoji's instead of words like "false" or "true" in order to make it easier to parse ✅ ❌ |
@metajack might also have some thoughts on presentation |
10f79c9
to
7b12689
Compare
I wonder if there's a way to present this data in a bit more condensed format for a majority of the data, maybe via a table or something? |
542ea7e
to
140565e
Compare
This is looking a ton better! Having the list of files in an expanding section works, but I think as it is there are too many expanding sections per dependency. Maybe the ones not listing files could be rolled into 1 larger table? |
140565e
to
6b45817
Compare
My thoughts so far:
Overall I think this is looking great. |
6b45817
to
f3300fd
Compare
f3300fd
to
da485f7
Compare
2a98b66
to
6f3eeb4
Compare
💣 This update introduces 1 known advisory💣 1 known advisory still unfixed🎉 This update fixes 1 known advisoryDependency update reviewtokio updated: 1.6.1 --> 1.8.1🎉 This update fixes known advisories
Cilck to show detailsClick to show version diff summary
Click to show changed files
Click to show changed files with unsafe code
hyper updated: 0.11.27 --> 0.12.0💣 The updated version contains known advisories
Cilck to show detailsClick to show version diff summary
Click to show changed files
Click to show changed files with unsafe code
|
🔒 Merge Conflict |
7be4ff1
to
e276c8e
Compare
resolved merge conflict locally |
/land |
Motivation
🎉 This update fixes 2 known advisories
Dependency update review
prost-build updated: 0.7.0 --> 0.8.0
Cilck to show details
Click to show version diff summary
Click to show changed files
third-party/protobuf/protoc-linux-x86_32
src/ident.rs
third-party/protobuf/protoc-osx-x86_64
third-party/protobuf/protoc-win32.exe
Cargo.toml.orig
src/lib.rs
third-party/protobuf/protoc-linux-aarch_64
src/ast.rs
src/code_generator.rs
third-party/protobuf/protoc-linux-x86_64
.cargo_vcs_info.json
build.rs
src/path.rs
Cargo.toml
Click to show modified build scripts
build.rs
prost updated: 0.7.0 --> 0.8.0
Cilck to show details
Click to show version diff summary
Click to show changed files
src/lib.rs
README.md
src/encoding.rs
benches/varint.rs
src/message.rs
Cargo.toml.orig
src/error.rs
Cargo.toml
.cargo_vcs_info.json
FUZZING.md
afl/.gitignore
Click to show changed files with unsafe code
src/encoding.rs
prost-types updated: 0.7.0 --> 0.8.0
🎉 This update fixes known advisories
Cilck to show details
Click to show version diff summary
Click to show changed files
Cargo.toml
src/lib.rs
Cargo.toml.orig
.cargo_vcs_info.json
tokio updated: 1.6.1 --> 1.8.1
🎉 This update fixes known advisories
Cilck to show details
Click to show version diff summary
Click to show changed files
src/io/util/read_until.rs
src/net/unix/datagram/socket.rs
.cargo_vcs_info.json
src/task/builder.rs
src/net/unix/listener.rs
src/io/async_fd.rs
tests/support/io_vec.rs
src/io/stdio_common.rs
src/net/tcp/split_owned.rs
src/net/unix/ucred.rs
tests/tcp_into_std.rs
tests/time_sleep.rs
tests/macros_test.rs
tests/sync_watch.rs
tests/time_pause.rs
src/runtime/task/join.rs
src/net/tcp/listener.rs
CHANGELOG.md
src/net/unix/split.rs
tests/sync_once_cell.rs
src/runtime/tests/task.rs
src/runtime/thread_pool/idle.rs
src/net/tcp/split.rs
src/sync/watch.rs
src/time/instant.rs
tests/async_send_sync.rs
src/net/windows/mod.rs
src/io/util/split.rs
src/future/trace.rs
src/runtime/task/waker.rs
src/runtime/builder.rs
src/time/driver/wheel/mod.rs
tests/rt_handle_block_on.rs
src/runtime/task/harness.rs
src/io/util/buf_stream.rs
src/sync/task/atomic_waker.rs
src/doc/os.rs
src/macros/select.rs
src/io/util/buf_reader.rs
Cargo.toml.orig
src/time/clock.rs
src/net/windows/named_pipe.rs
Cargo.toml
src/sync/rwlock.rs
src/time/driver/mod.rs
src/doc/winapi.rs
tests/io_buf_reader.rs
src/net/mod.rs
src/util/wake.rs
src/doc/mod.rs
src/runtime/basic_scheduler.rs
src/sync/broadcast.rs
tests/task_blocking.rs
tests/task_builder.rs
src/util/linked_list.rs
src/time/driver/sleep.rs
src/io/driver/mod.rs
src/time/mod.rs
src/sync/mpsc/error.rs
src/runtime/task/raw.rs
tests/macros_select.rs
src/runtime/task/core.rs
src/time/interval.rs
src/signal/unix/driver.rs
src/sync/mod.rs
tests/named_pipe.rs
src/net/unix/stream.rs
src/future/mod.rs
tests/uds_stream.rs
src/sync/once_cell.rs
src/io/async_write.rs
src/runtime/queue.rs
tests/task_abort.rs
src/io/util/buf_writer.rs
tests/rt_threaded.rs
src/net/tcp/stream.rs
tests/sync_rwlock.rs
src/net/udp.rs
docs/reactor-refactor.md
src/runtime/tests/loom_shutdown_join.rs
src/io/read_buf.rs
src/task/mod.rs
src/runtime/task/state.rs
tests/task_local_set.rs
src/task/spawn.rs
src/sync/mpsc/unbounded.rs
src/runtime/handle.rs
src/runtime/tests/queue.rs
tests/time_interval.rs
src/task/local.rs
src/macros/cfg.rs
src/runtime/spawner.rs
src/net/tcp/socket.rs
src/sync/mutex.rs
src/io/driver/scheduled_io.rs
src/sync/notify.rs
src/runtime/task/mod.rs
src/runtime/enter.rs
src/time/driver/entry.rs
src/util/trace.rs
src/sync/mpsc/bounded.rs
src/runtime/thread_pool/mod.rs
tests/io_buf_writer.rs
src/io/util/async_write_ext.rs
tests/io_copy_bidirectional.rs
src/io/util/async_read_ext.rs
src/lib.rs
src/runtime/blocking/pool.rs
src/runtime/tests/loom_queue.rs
src/sync/semaphore.rs
src/runtime/thread_pool/worker.rs
tests/uds_cred.rs
src/io/driver/interest.rs
src/runtime/tests/mod.rs
Click to show changed files with unsafe code
src/io/driver/scheduled_io.rs
src/io/read_buf.rs
src/net/tcp/listener.rs
src/net/tcp/socket.rs
src/net/tcp/stream.rs
src/net/udp.rs
src/net/unix/datagram/socket.rs
src/net/unix/listener.rs
src/net/unix/stream.rs
src/net/unix/ucred.rs
src/net/windows/named_pipe.rs
src/runtime/basic_scheduler.rs
src/runtime/queue.rs
src/runtime/task/core.rs
src/runtime/task/harness.rs
src/runtime/task/join.rs
src/runtime/task/mod.rs
src/runtime/task/raw.rs
src/runtime/task/waker.rs
src/runtime/tests/task.rs
src/runtime/thread_pool/worker.rs
src/signal/unix/driver.rs
src/sync/broadcast.rs
src/sync/mutex.rs
src/sync/notify.rs
src/sync/once_cell.rs
src/sync/rwlock.rs
src/sync/task/atomic_waker.rs
src/task/local.rs
src/time/driver/entry.rs
src/time/driver/mod.rs
src/time/driver/wheel/mod.rs
src/util/linked_list.rs
src/util/wake.rs
tests/io_buf_reader.rs
tests/named_pipe.rs
tests/support/io_vec.rs
tests/uds_cred.rs
prost-derive updated: 0.7.0 --> 0.8.0
Cilck to show details
Click to show version diff summary
Click to show changed files
Cargo.toml.orig
src/field/mod.rs
.cargo_vcs_info.json
Cargo.toml
src/field/scalar.rs
src/lib.rs
💣 This update introduces 1 known advisory
💣 1 known advisory still unfixed
🎉 This update fixes 1 known advisory
Dependency update review
tokio updated: 1.6.1 --> 1.8.1
🎉 This update fixes known advisories
Cilck to show details
Click to show version diff summary
Click to show changed files
src/io/driver/scheduled_io.rs
src/runtime/task/state.rs
src/future/trace.rs
src/net/unix/ucred.rs
src/sync/mod.rs
src/sync/mpsc/error.rs
tests/tcp_into_std.rs
tests/async_send_sync.rs
src/runtime/task/mod.rs
src/io/async_write.rs
src/net/unix/datagram/socket.rs
src/runtime/handle.rs
src/sync/mpsc/bounded.rs
tests/io_copy_bidirectional.rs
tests/macros_select.rs
docs/reactor-refactor.md
tests/task_builder.rs
src/runtime/spawner.rs
src/runtime/basic_scheduler.rs
tests/sync_rwlock.rs
tests/uds_stream.rs
src/runtime/task/core.rs
src/time/driver/wheel/mod.rs
src/runtime/queue.rs
tests/sync_once_cell.rs
src/runtime/tests/loom_shutdown_join.rs
src/net/tcp/listener.rs
tests/time_sleep.rs
src/io/util/read_until.rs
src/net/mod.rs
src/net/windows/named_pipe.rs
src/signal/unix/driver.rs
src/runtime/task/raw.rs
src/time/interval.rs
src/runtime/tests/mod.rs
src/runtime/task/join.rs
Cargo.toml.orig
src/runtime/task/waker.rs
src/task/builder.rs
src/net/tcp/split_owned.rs
src/io/util/buf_stream.rs
tests/time_pause.rs
src/sync/mutex.rs
src/sync/rwlock.rs
src/runtime/blocking/pool.rs
src/runtime/enter.rs
src/time/driver/mod.rs
tests/sync_watch.rs
src/io/stdio_common.rs
src/io/util/async_read_ext.rs
src/net/unix/stream.rs
src/sync/notify.rs
src/util/linked_list.rs
tests/time_interval.rs
tests/uds_cred.rs
tests/io_buf_reader.rs
src/net/tcp/socket.rs
src/time/instant.rs
src/time/clock.rs
src/io/util/buf_reader.rs
src/sync/watch.rs
src/net/tcp/stream.rs
src/macros/cfg.rs
src/io/read_buf.rs
src/runtime/task/harness.rs
src/runtime/tests/queue.rs
src/net/unix/listener.rs
src/runtime/thread_pool/mod.rs
src/sync/mpsc/unbounded.rs
Cargo.toml
src/doc/mod.rs
tests/io_buf_writer.rs
tests/named_pipe.rs
src/io/util/buf_writer.rs
src/io/async_fd.rs
src/future/mod.rs
src/net/udp.rs
src/io/driver/mod.rs
src/time/driver/sleep.rs
src/io/util/split.rs
src/util/trace.rs
tests/rt_threaded.rs
tests/task_abort.rs
tests/rt_handle_block_on.rs
src/net/tcp/split.rs
src/task/mod.rs
tests/task_blocking.rs
src/util/wake.rs
src/net/unix/split.rs
.cargo_vcs_info.json
tests/macros_test.rs
src/macros/select.rs
src/task/local.rs
src/sync/broadcast.rs
src/doc/os.rs
src/runtime/tests/task.rs
src/runtime/thread_pool/worker.rs
src/sync/task/atomic_waker.rs
src/runtime/tests/loom_queue.rs
src/time/mod.rs
tests/task_local_set.rs
src/doc/winapi.rs
src/io/driver/interest.rs
src/runtime/thread_pool/idle.rs
src/io/util/async_write_ext.rs
src/sync/once_cell.rs
src/lib.rs
src/task/spawn.rs
tests/support/io_vec.rs
src/sync/semaphore.rs
CHANGELOG.md
src/time/driver/entry.rs
src/net/windows/mod.rs
src/runtime/builder.rs
Click to show changed files with unsafe code
src/io/driver/scheduled_io.rs
src/io/read_buf.rs
src/net/tcp/listener.rs
src/net/tcp/socket.rs
src/net/tcp/stream.rs
src/net/udp.rs
src/net/unix/datagram/socket.rs
src/net/unix/listener.rs
src/net/unix/stream.rs
src/net/unix/ucred.rs
src/net/windows/named_pipe.rs
src/runtime/basic_scheduler.rs
src/runtime/queue.rs
src/runtime/task/core.rs
src/runtime/task/harness.rs
src/runtime/task/join.rs
src/runtime/task/mod.rs
src/runtime/task/raw.rs
src/runtime/task/waker.rs
src/runtime/tests/task.rs
src/runtime/thread_pool/worker.rs
src/signal/unix/driver.rs
src/sync/broadcast.rs
src/sync/mutex.rs
src/sync/notify.rs
src/sync/once_cell.rs
src/sync/rwlock.rs
src/sync/task/atomic_waker.rs
src/task/local.rs
src/time/driver/entry.rs
src/time/driver/mod.rs
src/time/driver/wheel/mod.rs
src/util/linked_list.rs
src/util/wake.rs
tests/io_buf_reader.rs
tests/named_pipe.rs
tests/support/io_vec.rs
tests/uds_cred.rs
hyper updated: 0.11.27 --> 0.12.0
💣 The updated version contains known advisories
Cilck to show details
Click to show version diff summary
Click to show changed files
src/header/common/if_match.rs
src/body/chunk.rs
src/header/common/allow.rs
src/header/common/strict_transport_security.rs
src/server/mod.rs
Cargo.toml.orig
src/header/common/access_control_max_age.rs
src/proto/h1/date.rs
src/client/compat.rs
src/header/common/content_encoding.rs
src/header/common/if_range.rs
src/header/common/access_control_allow_credentials.rs
src/proto/h2/mod.rs
src/proto/request.rs
src/service/new_service.rs
src/header/mod.rs
src/service/service.rs
src/header/common/range.rs
src/proto/h2/server.rs
src/body/mod.rs
src/header/common/transfer_encoding.rs
src/header/shared/encoding.rs
src/header/common/proxy_authorization.rs
src/header/common/if_modified_since.rs
src/header/common/content_disposition.rs
src/mock.rs
src/proto/h1/dispatch.rs
src/header/shared/entity.rs
src/header/common/authorization.rs
src/rt.rs
src/server/conn.rs
src/header/common/retry_after.rs
src/header/common/user_agent.rs
src/proto/h2/client.rs
src/client/connect.rs
src/body/payload.rs
src/header/common/last_modified.rs
src/version.rs
src/header/internals/vec_map.rs
src/method.rs
src/header/common/access_control_request_headers.rs
src/header/common/accept.rs
src/header/internals/mod.rs
src/header/common/expect.rs
src/header/common/connection.rs
src/error.rs
src/header/common/date.rs
src/header/common/pragma.rs
src/header/common/content_length.rs
src/header/common/origin.rs
src/header/common/if_unmodified_since.rs
src/header/common/etag.rs
src/proto/h1/conn.rs
src/header/parsing.rs
src/header/shared/charset.rs
src/header/common/if_none_match.rs
src/header/common/prefer.rs
src/header/shared/quality_item.rs
src/proto/chunk.rs
src/header/common/access_control_allow_origin.rs
src/common/never.rs
src/header/common/link.rs
src/header/shared/mod.rs
src/header/common/te.rs
src/body/body.rs
src/header/common/accept_encoding.rs
src/header/raw.rs
src/header/common/accept_ranges.rs
src/uri.rs
src/header/common/preference_applied.rs
src/proto/h1/role.rs
src/common/buf.rs
src/header/common/content_type.rs
src/header/common/location.rs
src/header/common/mod.rs
src/server/compat.rs
src/header/common/accept_language.rs
src/header/common/access_control_request_method.rs
src/header/common/last_event_id.rs
src/client/conn.rs
src/common/str.rs
src/header/common/from.rs
src/header/common/referrer_policy.rs
src/header/common/accept_charset.rs
src/server/tcp.rs
src/header/common/access_control_allow_headers.rs
src/proto/body.rs
src/headers.rs
src/header/shared/httpdate.rs
src/server/service.rs
src/lib.rs
src/common/mod.rs
src/status.rs
src/header/common/expires.rs
src/common/exec.rs
src/header/common/set_cookie.rs
src/header/internals/item.rs
src/header/common/content_language.rs
src/header/common/access_control_allow_methods.rs
src/server/rewind.rs
src/header/common/server.rs
src/header/common/warning.rs
src/proto/h1/mod.rs
src/proto/mod.rs
src/header/internals/cell.rs
src/service/mod.rs
src/header/common/access_control_expose_headers.rs
src/header/common/cookie.rs
src/client/dispatch.rs
src/header/common/content_range.rs
src/header/common/upgrade.rs
src/proto/response.rs
src/header/common/vary.rs
src/header/common/referer.rs
src/header/common/host.rs
src/client/pool.rs
src/proto/h1/encode.rs
src/server/server_proto.rs
src/client/tests.rs
src/header/common/cache_control.rs
src/proto/h1/io.rs
Cargo.toml
src/header/common/content_location.rs
src/client/mod.rs
Click to show changed files with unsafe code
src/common/str.rs
src/header/common/access_control_allow_credentials.rs
src/header/common/expect.rs
src/header/internals/cell.rs
src/header/internals/item.rs
src/header/mod.rs
src/headers.rs
src/proto/h1/io.rs
src/proto/h1/role.rs
src/server/mod.rs
src/server/rewind.rs
src/server/tcp.rs
src/uri.rs